Conversation
Signed-off-by: Nascs <[email protected]>
Signed-off-by: Nascs <[email protected]>
Signed-off-by: Nascs <[email protected]>
Signed-off-by: Nascs <[email protected]>
tingleby
approved these changes
Apr 19, 2024
Contributor
Author
|
Is there any issue blocking for this PR? Also can you take a look at #1126? Thanks. |
Contributor
Author
|
Hi @tingleby, if you have time, please check out this pr as well. |
Contributor
Author
|
Hi @tingleby, hope all is well, it's been a long time since you reviewed this pr, please correct me if anything is wrong if you had the time. Thanks. |
tingleby
approved these changes
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @tingleby, if you have time, take a look at this pr, it fixes a couple of issues where pwm doesn't work properly and standardizes radxa's pwm code style, thank you very much!